Skip to content

Update GoogleTest to latest version#241

Merged
mjcarroll merged 7 commits intomainfrom
bump_gtest
Jun 29, 2022
Merged

Update GoogleTest to latest version#241
mjcarroll merged 7 commits intomainfrom
bump_gtest

Conversation

@mjcarroll
Copy link
Contributor

Import latest version of GoogleTest from upstream and adjust build accordingly.

Tracking issue: gazebosim/gz-sim#1537

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from iche033 as a code owner June 28, 2022 06:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #241 (6fe3699) into main (484c408) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   68.68%   68.68%           
=======================================
  Files          34       34           
  Lines        3423     3423           
=======================================
  Hits         2351     2351           
  Misses       1072     1072           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484c408...6fe3699. Read the comment docs.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Jun 28, 2022
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll mjcarroll merged commit 075123d into main Jun 29, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 29, 2022 17:25
@Blast545
Copy link
Contributor

Blast545 commented Jun 30, 2022

👨‍🌾 It seems this PR introduced a build regression on the MacOS buildfarm:
ignition_sensors-ci-main-homebrew-amd64#52

It's failing to find gtest/gtest.h so I think it's related to this PR, can I ask you to take a look? @mjcarroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden tests Broken or missing tests / testing infra

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants