Skip to content

Fix msgs.hh uses#263

Merged
chapulina merged 1 commit intogz-sensors7from
chapulina/7/msgs.hh
Aug 29, 2022
Merged

Fix msgs.hh uses#263
chapulina merged 1 commit intogz-sensors7from
chapulina/7/msgs.hh

Conversation

@chapulina
Copy link
Contributor

🦟 Bug fix

Required by

Summary

Include the narrowest headers for faster compilation.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Aug 27, 2022
@chapulina chapulina requested a review from mjcarroll August 27, 2022 04:23
@chapulina chapulina requested a review from iche033 as a code owner August 27, 2022 04:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 27, 2022
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #263 (183ce30) into gz-sensors7 (da58993) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-sensors7     #263   +/-   ##
============================================
  Coverage        67.75%   67.75%           
============================================
  Files               35       35           
  Lines             3734     3734           
============================================
  Hits              2530     2530           
  Misses            1204     1204           
Impacted Files Coverage Δ
src/BoundingBoxCameraSensor.cc 58.49% <ø> (ø)
src/CameraSensor.cc 77.17% <ø> (ø)
src/DepthCameraSensor.cc 74.08% <ø> (ø)
src/LogicalCameraSensor.cc 90.14% <ø> (ø)
src/RgbdCameraSensor.cc 75.41% <ø> (ø)
src/SegmentationCameraSensor.cc 53.90% <ø> (ø)
src/ThermalCameraSensor.cc 60.98% <ø> (ø)
src/WideAngleCameraSensor.cc 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same tests are failing, is this expected?

@scpeters
Copy link
Member

scpeters commented Aug 27, 2022

Same tests are failing, is this expected?

for homebrew, the same test is failing on gz-sensors7: https://build.osrfoundation.org/view/ign-garden/job/ignition_sensors-ci-gz-sensors7-homebrew-amd64/1/testReport/junit/(root)/INTEGRATION_wide_angle_camera/test_ran/

and for windows, the same 14 tests are failing: https://build.osrfoundation.org/view/ign-garden/job/ign_sensors-gz-7-win/1/

@scpeters
Copy link
Member

ABI checker failure is not relevant until the stable release, but it is failing due to a bug in release-tools: gazebo-tooling/release-tools#808

@scpeters
Copy link
Member

Same tests are failing, is this expected?

I also see the same Github actions test failures in Jammy on the latest commit to gz-sensors7: da58993

@scpeters
Copy link
Member

homebrew CI builds successfully with this branch (using gazebosim/gz-sim#1566)

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks reasonable to me

@chapulina chapulina dismissed ahcorde’s stale review August 29, 2022 16:53

No new test failures

@chapulina chapulina merged commit f2c3dca into gz-sensors7 Aug 29, 2022
@chapulina chapulina deleted the chapulina/7/msgs.hh branch August 29, 2022 16:54
@scpeters scpeters restored the chapulina/7/msgs.hh branch August 30, 2022 00:04
@scpeters scpeters deleted the chapulina/7/msgs.hh branch August 30, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working 🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants