Skip to content

Clear scene before exiting wide_angle_camera_test#266

Merged
ahcorde merged 5 commits intogz-sensors7from
cleanup_wide_angle_camera
Sep 19, 2022
Merged

Clear scene before exiting wide_angle_camera_test#266
ahcorde merged 5 commits intogz-sensors7from
cleanup_wide_angle_camera

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Sep 12, 2022

🦟 Bug fix

This fixes the INTEGRATION_wide_angle_camera test for me locally on macOS. For some reason, we have to remove the sensor and scene visuals manually in this test otherwise it segfaults on macOS while cleaning up shared pointers. This does not happen on Ubuntu.

Related PR: gazebosim/gz-rendering#718

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #266 (bd77525) into gz-sensors7 (86b42a2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-sensors7     #266   +/-   ##
============================================
  Coverage        67.75%   67.75%           
============================================
  Files               35       35           
  Lines             3734     3734           
============================================
  Hits              2530     2530           
  Misses            1204     1204           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde enabled auto-merge (squash) September 19, 2022 07:56
@ahcorde ahcorde merged commit 6b84408 into gz-sensors7 Sep 19, 2022
@ahcorde ahcorde deleted the cleanup_wide_angle_camera branch September 19, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants