Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
2 tasks
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #270 +/- ##
============================================
Coverage 67.75% 67.75%
============================================
Files 35 35
Lines 3734 3734
============================================
Hits 2530 2530
Misses 1204 1204 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
reviewed
Sep 17, 2022
tutorials/thermal_camera.md
Outdated
| #include <cstdint> | ||
|
|
||
| #include <gz/msgs.hh> | ||
| #include <gz/msgs/image.pb> |
Contributor
Author
There was a problem hiding this comment.
Instead of including all messages, we just include the one that is required fot this example
Contributor
There was a problem hiding this comment.
oh I mean the .h file extension is missing
tutorials/thermal_camera.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Use this `CMakeLists.txt` to compile the code |
Contributor
There was a problem hiding this comment.
mention to save file as main.cpp? e.g.
Save the above code to a file named `main.cpp` and use this `CMakeLists.txt` to build it
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
iche033
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Improved thermal camera tutorial. Related with gazebosim/garden-tutorial-party#573
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.