Skip to content

Fixed INTEGRATION triggered_camera test#272

Merged
ahcorde merged 2 commits intogz-sensors7from
ahcorde/fix/integration_triggered_camera
Sep 16, 2022
Merged

Fixed INTEGRATION triggered_camera test#272
ahcorde merged 2 commits intogz-sensors7from
ahcorde/fix/integration_triggered_camera

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 16, 2022

🦟 Bug fix

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 16, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (gz-sensors7@4101838). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             gz-sensors7     #272   +/-   ##
==============================================
  Coverage               ?   67.75%           
==============================================
  Files                  ?       35           
  Lines                  ?     3734           
  Branches               ?        0           
==============================================
  Hits                   ?     2530           
  Misses                 ?     1204           
  Partials               ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde marked this pull request as ready for review September 16, 2022 21:33
@ahcorde ahcorde requested a review from iche033 as a code owner September 16, 2022 21:33
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me.

@ahcorde ahcorde enabled auto-merge (squash) September 16, 2022 21:41
@ahcorde ahcorde merged commit 002398e into gz-sensors7 Sep 16, 2022
@ahcorde ahcorde deleted the ahcorde/fix/integration_triggered_camera branch September 16, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants