This repository was archived by the owner on Aug 14, 2024. It is now read-only.
feat: Note about sample rates for tracing #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/a0aqwfipk/sentry.dev |
rhcarvalho
commented
Jun 23, 2020
| @@ -6,7 +6,7 @@ This document covers how unified SDKs should implement AM. | |||
| Things listed here are in no specific order, cover the API shape and not how it should be internally implemented. | |||
| Read this fully before asking questions. | |||
|
|
|||
| See [https://github.com/getsentry/sentry-javascript](https://github.com/getsentry/sentry-javascript) | |||
| See [https://github.com/getsentry/sentry-javascript](https://github.com/getsentry/sentry-javascript) | |||
There was a problem hiding this comment.
Small whitespace fix bundled together here.
AbhiPrasad
approved these changes
Jun 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double sampling has happened accidentally both in JS and Python, and fixed in getsentry/sentry-javascript#2600 and getsentry/sentry-python#732, respectively.