Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat: Note about sample rates for tracing #66

Merged
merged 1 commit into from
Jun 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/docs/sdk/unified-api/tracing.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This document covers how unified SDKs should implement AM.
Things listed here are in no specific order, cover the API shape and not how it should be internally implemented.
Read this fully before asking questions.

See [https://github.com/getsentry/sentry-javascript](https://github.com/getsentry/sentry-javascript)
See [https://github.com/getsentry/sentry-javascript](https://github.com/getsentry/sentry-javascript)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small whitespace fix bundled together here.


or

Expand All @@ -17,6 +17,11 @@ or
- `1.0` (100% delivery rate) means send all transactions
- Value is expressed in `0.0` - `1.0` float, ranged from 0% to 100% rate
- Default makes AM an opt-in feature
- Transactions should be sampled only by `tracesSampleRate`.
The `sampleRate` configuration is used for error events and should not
apply to transactions. Pay special attention not to incur in evaluating
the sampling decision twice for transaction events from their creation
until their delivery to Sentry.
- Introduce `Sentry.startTransaction`
- Internally this creates a `Transaction` and returns the instance
- Users need to interact with the instance and keep track of it themselves
Expand Down