feat(suspect-commits): Add event cause events #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reload_app/events.py
Outdated
| "feature.event_cause.viewed": { | ||
| "org_id": int, | ||
| "project_id": int, | ||
| "platform": str, |
adhiraj
approved these changes
Jul 19, 2019
reload_app/events.py
Outdated
| @@ -160,6 +160,26 @@ | |||
| "org_id": int, | |||
| "plan": str, | |||
| }, | |||
| "feature.event_cause.viewed": { | |||
There was a problem hiding this comment.
not sure why we have a feature. prefix?
There was a problem hiding this comment.
hm ya not sure if this is for organizational reasons or if there's reporting that relies on it. I can remove the prefix
maheskett
force-pushed
the
maheskett/add-suspect-commit-analytics
branch
from
8ce327e to
d1a4d3d
Compare
adhiraj
reviewed
Jul 19, 2019
| @@ -99,6 +99,25 @@ | |||
| "path": str, | |||
| "org_id": int, | |||
| }, | |||
| "event_cause.viewed": { | |||
| "org_id": int, | |||
| "project_id": int, | |||
There was a problem hiding this comment.
why no platform here? basically i'm thinking if we wanna answer the question "what is the dismiss rate for different platforms?" what is the data we'll need
There was a problem hiding this comment.
that event is only going to reload. thought you could get the platform in that case?
There was a problem hiding this comment.
Yeah we can join project right?
maheskett
force-pushed
the
maheskett/add-suspect-commit-analytics
branch
from
d1a4d3d to
5225a2e
Compare
evanpurkhiser
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.