feat(suspect-commits): Add analytics events #14080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheskett
force-pushed
the
maheskett/event-cause-analytics
branch
from
826baca to
fa947e0
Compare
adhiraj
reviewed
Jul 19, 2019
| trackAnalyticsEvent({ | ||
| eventKey, | ||
| eventName, | ||
| org_id: parseInt(organization.id, 10), |
There was a problem hiding this comment.
shouldn't this be organization_id
There was a problem hiding this comment.
🙏 that we have type script soon
There was a problem hiding this comment.
hm where are you seeing that? it's org_id in reload
There was a problem hiding this comment.
There was a problem hiding this comment.
ah okay. maybe we could make these more consistent later, since it looks like trackAdhocEvent and analytics use org_id
maheskett
force-pushed
the
maheskett/event-cause-analytics
branch
from
fa947e0 to
7fa5686
Compare
maheskett
force-pushed
the
maheskett/event-cause-analytics
branch
from
2f6738a to
f171a38
Compare
| trackAnalyticsEvent({ | ||
| eventKey, | ||
| eventName, | ||
| organization_id: parseInt(organization.id, 10), |
There was a problem hiding this comment.
minor nit: These will be coerced for you, you don't have to manually parse int.
evanpurkhiser
approved these changes
Jul 19, 2019
HazAT
added a commit
that referenced
this pull request
Jul 23, 2019
* master: (25 commits) ref(onboarding): Fix install promprt URL (#14106) fix(app-platform): Allow GET requests for published apps (#14109) feat: Update Group.get_latest_event to use Snuba event (#14039) ref(onboarding): Rename wizardNew -> onboarding (#14104) feat(apm): Update props to address proptype warnings for new transaction attributes (SEN-800) (#14040) ref(ui): Move and codesplit `ProjectPlugins` (#13952) feat(typescript): Add TypeScript compatibility (#13786) ref(templates): Remove unused content block default (#14090) ref(less): Remove unused admin.less (#14097) ref(onobarding): Remove old onboarding experience (#14066) fix(ui) Fix missing conditions in tag bars (#14063) ref(suspect-commits): Add hook (#14057) ref(frontend): Segment frontend web urls (#14096) feat(suspect-commits): Add analytics events (#14080) feat(servicehooks): Update servicehook URLs (#14093) license: Remove license headers (#14095) ref(templates): Remove unused account_nav (#14091) fix: Disable transaction events in store (#14088) fix(InstallWizard): Fix exception when InstallWizard completed (#14092) ref(admin): Fix thrashing on stat charts (#14094) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add analytics events for views and button clicks. Depends on #117