Skip to content

Add Angular-SDK-specific source map upload instructions #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lms24 opened this issue Feb 20, 2023 · 0 comments · Fixed by #6404
Closed

Add Angular-SDK-specific source map upload instructions #6326

Lms24 opened this issue Feb 20, 2023 · 0 comments · Fixed by #6404
Assignees
@Lms24

Comments

@Lms24
Copy link
Member

Lms24 commented Feb 20, 2023 •
edited
Loading

Core or SDK?

Platform/SDK

Which part? Which one?

@sentry/angular

Description

Following up on a recent customer call:

Using the Sentry Webpack Plugin isn't as simple in Angular as in other frameworks: Before adding our plugin, users need to replace the default Angular builder w/ a custom builder.

Suggested Solution

While this arguably decreases the likelihood that people would use the plugin, we should nevertheless show them how they can use it.
@Lms24 Lms24 self-assigned this Feb 20, 2023
@Lms24 Lms24 mentioned this issue Feb 24, 2023
Merged
Lms24 added a commit that referenced this issue Feb 28, 2023
@Lms24 @ranma42 @lizokm
ref(angular): Update Angular SDK docs for @sentry/angular-ivy (#6356)
556e41c 
To ensure first-class compatibility with Angular's "new" rendering engine, Ivy, we needed to create a new SDK package that's compiled differently than the original `@sentry/angular` package. This new SDK is compatible with Angular 12 and newer and hence we're going to make it the default SDK in the docs going forward.

This PR 
* Updates the Angular version <-> Sentry SDK compatibility description with a table
  * I added entries for Angular 1/AngularJS (this came up recently in a Slack convo) and Angular 2-9 with a message that we do not support these versions anymore in v7 of the SDKs. Happy to make changes here if reviewers think this shouldn't be promoted.
* Updates imports and code snippets with versions for Angular 12+ (ivy) and Angular 10/11
* Updates the SDK onboarding wizard docs (+ Replay onboarding)
* Adds an Angular-specific verify code snippet which was missing before
* Adds file names to all angular code snippets (this came up in #6326 and it was easiest to just do it in this PR)
* streamlines the Angular "Getting started" page and fixes a few typos/wording issues

Co-authored-by: Andrea Canciani <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
@Lms24 Lms24 mentioned this issue Mar 2, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(angular): Add Angular CLI + Webpack Plugin sourcemaps upload guide getsentry/sentry-docs
1 participant
@Lms24