ref(angular): Update Angular SDK docs for @sentry/angular-ivy
#6356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
mydea and
AbhiPrasad
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
changed the title
@sentry/angular-ivy@sentry/angular-ivy
- update version compatibility table - different tabs for angular 12+ and 10/11 - update verify include w/ NG-specific example - add filenames to all code examples - streamline getting started - fix a few wording issues/typos
Lms24
force-pushed
the
lms/angular-ivy-docs
branch
from
d7c5bdf to
6712083
Compare
Lms24
commented
Feb 24, 2023
Comment on lines
15
to
24
| ```bash | ||
| # Using yarn | ||
| # Using yarn (Angular 12+) | ||
| yarn add @sentry/angular-ivy @sentry/tracing | ||
| # Using yarn (Angular 10 and 11) | ||
| yarn add @sentry/angular @sentry/tracing | ||
|
|
||
| # Using npm | ||
| # Using npm (Angular 12+) | ||
| npm install --save @sentry/angular-ivy @sentry/tracing | ||
| # Using npm (Angular 10 and 11) | ||
| npm install --save @sentry/angular @sentry/tracing |
There was a problem hiding this comment.
I know this is ugly but afaik we can't use tabs in the onboarding wizard :(
ranma42
reviewed
Feb 27, 2023
src/platform-includes/performance/enable-automatic-instrumentation/javascript.mdx
Outdated
Show resolved
Hide resolved
ranma42
reviewed
Feb 27, 2023
ranma42
reviewed
Feb 27, 2023
Co-authored-by: Andrea Canciani <[email protected]>
lizokm
approved these changes
Feb 27, 2023
src/platform-includes/getting-started-install/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-verify/javascript.angular.mdx
Outdated
Show resolved
Hide resolved
lforst
approved these changes
Feb 28, 2023
Co-authored-by: Liza Mock <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure first-class compatibility with Angular's "new" rendering engine, Ivy, we needed to create a new SDK package that's compiled differently than the original
@sentry/angularpackage. This new SDK is compatible with Angular 12 and newer and hence we're going to make it the default SDK in the docs going forward.This PR
ref: getsentry/sentry-javascript#7265