Skip to content

fix(replay): Fix crash on devices with the Unisoc/Spreadtrum T606 chipset #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 11, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 6, 2025

📜 Description

  • Check chipset (only available on API 31 and above) for the faulty one and use software canvas instead of hardware canvas.

See replay from one of the devices: https://sentry-sdks.sentry.io/replays/17e3e42695c945378af6689e2aa35b7b/

💡 Motivation and Context

Fixes #4411

💚 How did you test it?

Manually on one of the faulty devices

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 444.96 ms 491.42 ms 46.46 ms
Size 1.58 MiB 2.08 MiB 511.31 KiB

Previous results on branch: rz/fix/session-replay-unisoc-chipset

Startup times

Revision Plain With Sentry Diff
f565dae 423.59 ms 447.04 ms 23.45 ms

App size

Revision Plain With Sentry Diff
f565dae 1.58 MiB 2.08 MiB 511.23 KiB

@markushi markushi merged commit 260324f into main Jun 11, 2025
33 checks passed
@markushi markushi deleted the rz/fix/session-replay-unisoc-chipset branch June 11, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Session Replay] Crashes on Spreadtrum T606 chipset
2 participants