Address PR feedback #4481
Merged
Address PR feedback #4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn,
stefanosiano and
lcian
as code owners
Performance metrics 🚀
|
stefanosiano
approved these changes
Jun 11, 2025
markushi
merged commit 8849dcd
into
rz/fix/session-replay-unisoc-chipset
33 of 34 checks passed
markushi
deleted the
markushi/fix/session-replay-unisoc-chipset-pr-feedback
branch
markushi
added a commit
that referenced
this pull request
Jun 11, 2025
…pset (#4477) * fix(replay): Do not capture replay for cached events * Changelog * Formatting * Wording * Still caputre replay for outbox events * fix(replay): Fix crash on devices with the Unisoc/Spreadtrum T606 chipset * typo * Changelog * Address PR feedback (#4481) * Address PR feeback * Cleanup --------- Co-authored-by: Markus Hintersteiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Addresses feedback from here: https://github.com/getsentry/sentry-java/pull/4477/files#r2131959353
💡 Motivation and Context
💚 How did you test it?
#skip-changelog
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps