Skip to content

Intercept window.open to ignore slow clicks #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
billyvg opened this issue Jun 7, 2023 · 1 comment · Fixed by #8308
Closed

Intercept window.open to ignore slow clicks #8301

billyvg opened this issue Jun 7, 2023 · 1 comment · Fixed by #8308
Assignees
@mydea
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@billyvg
Copy link
Member

billyvg commented Jun 7, 2023

We are getting a lot of false positives from links that open a new window using window.open() - let's investigate intercepting window.open when tracking slow clicks, and ignoring the slow click when window.open() is called.
@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label Jun 7, 2023
@bruno-garcia bruno-garcia mentioned this issue Jun 7, 2023
Closed
@bruno-garcia
Copy link
Member

We need to gate the backend detection by whatever version we ship this fix

@bruno-garcia bruno-garcia mentioned this issue Jun 8, 2023
Closed
@mydea mydea mentioned this issue Jun 9, 2023
Merged
@mydea mydea self-assigned this Jun 12, 2023
mydea added a commit that referenced this issue Jun 19, 2023
@mydea
feat(replay): Consider window.open for slow clicks (#8308)
1bdf2d9 
When a click triggers `window.open()`, do not consider it a slow click.

Closes #8301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Consider window.open for slow clicks getsentry/sentry-javascript
3 participants
@billyvg @bruno-garcia @mydea