Replay: Hide Slow/dead/rage click breadcrumb #50590
Assignees
Labels
Comments
|
I disagree we should hide the breadcrumbs in the UI, I think the breadcrumbs are pretty "low stakes" compared to notifications. It's additional context for the user as they are viewing the replay. Showing these breadcrumbs for users will allow to us to start gather real user feedback while we decide how to best use this data. |
ryan953
added a commit
that referenced
this issue
Jun 16, 2023
) The idea here is that we can have some standard base-types (BreadcrumbFrame, SpanFrame, and ErrorFrame) which we can return from our ReplayReader instance. With memoized returns we can reduce the amount of iterations that we run against the arrays whenever we're switching tabs in the Replay Details view, this will come at a cost of some more memory. This PR focuses on adding the new hydrated type definitions, and doing the up-front work to insert missing fields to make things consistent and easy to use. More fields could be added over time too (like bringing back `transformCrumbs()` or some more specific version.) To follow up we will need to go through each component and convert types into the new *Frame system. The only tough areas will be the Breadcrumb List and Timeline. Both of those expect arrays of type Breadcrumb, but not they'll be getting Breadcrumb, Spans, and Errors mixed together. It'll be a small matter of some if-statements and then using the correct field. Related to #47991 Fixes #50590 Fixes #46130
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
We've collecting breadcrumbs for Slow Clicks as part of:
Since we're aware of some false positives, for example:
window.opento ignore slow clicks sentry-javascript#8301)Lets hide the breadcrumbs from the UI until we're comfortable with the detection logic.
For debugging purposes, we'll let them be visible to ourselves (we'll feature flag it)
The text was updated successfully, but these errors were encountered: