-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Client Report Support #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
498fa19
to
e5ce2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review, will do in more detail after DACI is ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at tests yet.
e107443
to
7d924e7
Compare
cd5162c
to
0e585c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok nice, I think we are good to go
We'll cut the beta release from this branch, so I will hold with merging it to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor feedback.
01c3c4f
to
b65a83b
Compare
🚀 |
73480d5
to
a7eaf2f
Compare
385caf5
to
a787894
Compare
This adds support for client reports to the Browser SDK. This will cause the SDK to send a report once the tab goes hidden or has been closed and will send it as a separate envelope.
The feature can be turned off via the
sendClientReports
option which is on by default.Refs:
getsentry/relay#1074
getsentry/sentry-python#1181