Skip to content

ref(build): Use base rollup config function in @sentry/integrations #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

ref(build): Use base rollup config function in @sentry/integrations #4652

merged 1 commit into from
Mar 1, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Mar 1, 2022 •
edited
Loading

This uses the config-generating function introduced in #4650 to generate the rollup config for the integrations package. There is no effect on bundle contents.

Ref: https://getsentry.atlassian.net/browse/WEB-638

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022 •
edited
Loading

size-limit report

Path Base Size (d83d231) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.77 KB -0.01% 🔽
@sentry/browser - ES5 CDN Bundle (minified) 63.47 KB 63.47 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.44 KB 18.44 KB -0.02% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.6 KB 56.6 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.2 KB 22.2 KB 0%
@sentry/browser - Webpack (minified) 76.36 KB 76.36 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.23 KB 22.23 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.4 KB 46.4 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.23 KB 27.23 KB -0.01% 🔽

@lobsterkatie lobsterkatie force-pushed the kmclb-use-base-rollup-config-function-integrations branch from 28be0a1 to 0a02329 Compare March 1, 2022 08:17
@lobsterkatie lobsterkatie force-pushed the kmclb-use-base-rollup-config-function-integrations branch from 0a02329 to 9fbe555 Compare March 1, 2022 14:19
@lobsterkatie lobsterkatie marked this pull request as ready for review March 1, 2022 14:35
@lobsterkatie lobsterkatie requested a review from AbhiPrasad March 1, 2022 14:35
@lobsterkatie lobsterkatie merged commit b692ffb into master Mar 1, 2022
@lobsterkatie lobsterkatie deleted the kmclb-use-base-rollup-config-function-integrations branch March 1, 2022 14:53
AbhiPrasad pushed a commit that referenced this pull request Mar 2, 2022
@lobsterkatie @AbhiPrasad
ref(build): Use base rollup config function in @sentry/integrations (…
d520fe3 
…#4652)

This uses the config-generating function introduced in #4650 to generate the rollup config for the integrations package. There is no effect on bundle contents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @AbhiPrasad