ref(build): Programmatically generate base CDN rollup config #4650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-programmatically-generate-base-CDN-rollup-config
branch
from
258e35f to
390a0e2
Compare
AbhiPrasad
approved these changes
Mar 1, 2022
lobsterkatie
deleted the
kmclb-programmatically-generate-base-CDN-rollup-config
branch
lobsterkatie
added a commit
that referenced
this pull request
Mar 1, 2022
…4654) This builds on #4650, which introduced a function to generate rollup configs for our CDN bundles, allowing that function to handle both ES5 and ES6 compilation. No change to bundle contents. Note: This doesn't make any difference for the four packages the change is applied to here, but will enable `@sentry/browser` to use the new config generation function, a change which will come in a future PR.
lobsterkatie
added a commit
that referenced
this pull request
Mar 2, 2022
As part of centralizing and unifying our CDN rollup config, this uses the config generation function introduced in #4650 to generate the config for all browser bundles. Unlike many of the other PRs in this series, this one does actually have an effect on certain bundles, to wit: - `_mergeOptions` is no longer a protected-from-minifcation property, as it's about to be extracted into a stand-alone function. (See #4625.) - Up until this point, one difference between the `@sentry/browser` rollup config and all of the other rollup configs was the former's use of the `__SENTRY_NO_DEBUG__` flag to suppress logs in the minified bundles. Rather than add a parameter to the function controlling whether or not each package should use the flag, I decided it was better to just apply the flag to all minified bundles.
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 2, 2022
…4654) This builds on #4650, which introduced a function to generate rollup configs for our CDN bundles, allowing that function to handle both ES5 and ES6 compilation. No change to bundle contents. Note: This doesn't make any difference for the four packages the change is applied to here, but will enable `@sentry/browser` to use the new config generation function, a change which will come in a future PR.
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 2, 2022
As part of centralizing and unifying our CDN rollup config, this uses the config generation function introduced in #4650 to generate the config for all browser bundles. Unlike many of the other PRs in this series, this one does actually have an effect on certain bundles, to wit: - `_mergeOptions` is no longer a protected-from-minifcation property, as it's about to be extracted into a stand-alone function. (See #4625.) - Up until this point, one difference between the `@sentry/browser` rollup config and all of the other rollup configs was the former's use of the `__SENTRY_NO_DEBUG__` flag to suppress logs in the minified bundles. Rather than add a parameter to the function controlling whether or not each package should use the flag, I decided it was better to just apply the flag to all minified bundles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new build process, this continues the work centralizing the rollup config for our CDN bundles. More specifically, this creates a function to generate the base configs for
@sentry/tracing,@sentry/vue, and@sentry/wasm, and changes each of their respective rollup configs to use it. As expected with a pure refactor, there are no bundle changes.Not included in this PR are
@sentry/browserand@sentry/integrations. Because their respective rollup configs are more complicated, they'll be handled in future PRs. As a result, code which will, once those are handled, replace much of the code in the repo-levelrollup.config.jshas instead been added, so as to not break their current build processes.Note that the added dev dependency doesn't actually change
yarn.lock, becausedeepmergeis already included, as a transitive dependency.ref: https://getsentry.atlassian.net/browse/WEB-632