ref(build): Handle JS version in rollup config generation function #4654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 1, 2022
lobsterkatie
force-pushed
the
kmclb-handle-js-version-rollup-config-function
branch
from
3ed0dd0 to
51e67e3
Compare
size-limit report
|
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 2, 2022
…4654) This builds on #4650, which introduced a function to generate rollup configs for our CDN bundles, allowing that function to handle both ES5 and ES6 compilation. No change to bundle contents. Note: This doesn't make any difference for the four packages the change is applied to here, but will enable `@sentry/browser` to use the new config generation function, a change which will come in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #4650, which introduced a function to generate rollup configs for our CDN bundles, allowing that function to handle both ES5 and ES6 compilation. No change to bundle contents.
Note: This doesn't make any difference for the four packages the change is applied to in this PR, but will enable
@sentry/browserto use the new config generation function, a change which will come in a future PR.Ref: https://getsentry.atlassian.net/browse/WEB-644