feat(utils): Convert Logger class to functions #4863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
v7-abhi-logger-functions
branch
3 times, most recently
from
94a679b to
4d489e5
Compare
AbhiPrasad
changed the title
AbhiPrasad
changed the title
size-limit report 📦
|
AbhiPrasad
commented
Apr 6, 2022
| * | ||
| * @param callback The function to run against the original `console` messages | ||
| * @returns The results of the callback | ||
| */ | ||
| export function consoleSandbox(callback: () => any): any { | ||
| export function consoleSandbox<T>(callback: () => T): T { |
There was a problem hiding this comment.
as a next step, we can further refactor consoleSandbox to take a level argument, so we don't have to un-patch and re-patch every single console level every time we call this.
AbhiPrasad
force-pushed
the
v7-abhi-logger-functions
branch
from
4d489e5 to
5810ace
Compare
|
Seems Node 6 tests are failing because |
lforst
approved these changes
Apr 6, 2022
3 tasks
|
@AbhiPrasad I believe this caused #4878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #4860
Based on work in #4285
Removes the logger class in favour of a function + object. They are functionality identical. While I was here, took the liberty to refactor
consoleSandboxa little, mainly adjusting the types.Resolves https://getsentry.atlassian.net/browse/WEB-604
Note: This can be merged before
v7because@sentry/utilsis not considered public API.