fix(typing): Fix typing API in CaptureConsle #4879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Apr 7, 2022
kamilogorek
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Approving to unblock, but you should consider this fix, see https://github.com/getsentry/sentry-javascript/blob/master/packages/tracing/src/integrations/node/mongo.ts#L7-L10
| @@ -18,12 +18,12 @@ export class CaptureConsole implements Integration { | |||
| /** | |||
| * @inheritDoc | |||
| */ | |||
| private readonly _levels: typeof CONSOLE_LEVELS = CONSOLE_LEVELS; | |||
| private readonly _levels: readonly string[] = CONSOLE_LEVELS; | |||
There was a problem hiding this comment.
Suggested change
| private readonly _levels: readonly string[] = CONSOLE_LEVELS; | |
| private readonly _levels: typeof CONSOLE_LEVELS[number] = CONSOLE_LEVELS; |
There was a problem hiding this comment.
Thought about that one too but that would still break the API. It was string[] before and doing typeof CONSOLE_LEVELS[number] is stricter than that. We could do that in the major bump however.
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public constructor(options: { levels?: typeof CONSOLE_LEVELS } = {}) { | ||
| public constructor(options: { levels?: string[] } = {}) { |
There was a problem hiding this comment.
Suggested change
| public constructor(options: { levels?: string[] } = {}) { | |
| public constructor(options: { levels?: typeof CONSOLE_LEVELS[number] } = {}) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4878 which got introduced in #4863