Skip to content

feat(remix): Add Remix client SDK. #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jun 15, 2022

Part 2 of #4894

Adds client side SDK for error tracking / performance tracing of Remix.

  • Uses React SDK underneath, and requires <ErrorBoundary /> to properly catch errors.
  • Supports parameterized route paths with remixRouterInstrumentation and withSentryRouteTracing.

Manually Tested:

Need to add tests for performance / routing.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.43 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 60.21 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.24 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.83 KB (added)
@sentry/browser - Webpack (gzipped + minified) 20 KB (added)
@sentry/browser - Webpack (minified) 65.2 KB (added)
@sentry/react - Webpack (gzipped + minified) 20.02 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.02 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.63 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.16 KB (added)

@AbhiPrasad AbhiPrasad added this to the Sentry Remix SDK milestone Jun 15, 2022
@AbhiPrasad AbhiPrasad self-requested a review June 15, 2022 18:41
@AbhiPrasad AbhiPrasad mentioned this pull request Jun 15, 2022
26 tasks
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way we can automatically inject the ErrorBoundary?

@AbhiPrasad AbhiPrasad merged commit ef30920 into master Jun 15, 2022
@AbhiPrasad AbhiPrasad deleted the onur/remix-sdk-client branch June 15, 2022 20:09
@onurtemizkan
Copy link
Collaborator Author

Is there some way we can automatically inject the ErrorBoundary?

I'll try injecting with the route wrapper 👍

lobsterkatie added a commit that referenced this pull request Jun 16, 2022
This is a follow-up to #5256 and #5264, which added a skeleton remix SDK to the repo. The template that was used to create the new package had parts of the 6.x package structure and configuration still in it. This fixes that by bringing everything up to date to match our other packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants