chore(remix): Update package to 7.x structure #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Jun 16, 2022
| "@sentry/utils": "7.1.1", | ||
| "@sentry/webpack-plugin": "1.18.9", | ||
| "tslib": "^1.9.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@sentry/types": "7.1.1", |
There was a problem hiding this comment.
Because it's supposed to be a regular dependency, as it is in all of our other packages. Because we don't ship types directly in our SDKs, our users need @sentry/types if they're using TS.
|
FYI @onurtemizkan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #5256 and #5264, which added a skeleton Remix SDK to the repo. The template that was used to create the new package had parts of the 6.x package structure and configuration still in it. This fixes that by bringing everything up to date to match our other packages.