feat: Add event.type property to Events and Discover #13100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
requested changes
May 7, 2019
src/sentry/utils/snuba.py
Outdated
| @@ -44,6 +44,7 @@ | |||
| # general | |||
| 'id': 'event_id', | |||
| 'project.id': 'project_id', | |||
| 'type': 'type', | |||
There was a problem hiding this comment.
We already have this as event.type. Looking back at the history of this, we did it because existing users are already using type as a tag, and this would override that. Better to just use event.type in discover, since it already works in event/issue search.
There was a problem hiding this comment.
@saragilford Any thoughts on naming here?
There was a problem hiding this comment.
I think because we have so many projects using type, I'm hesitant to ask people to change their tag usage (anything that requires our users to make code changes is a hard sell). While event.type is not the most elegant, it's the right choice for us to commit to.
lynnagara
changed the title
wedamija
approved these changes
May 10, 2019
lynnagara
added a commit
that referenced
this pull request
Jul 18, 2019
'type' column is already on this list, was accidentally re-added as part of #13100
lynnagara
added a commit
that referenced
this pull request
Jul 18, 2019
'type' column is already on this list, was accidentally re-added as part of #13100
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event.type to events and issue search, events table and Discover columns
Closes SEN-694