Skip to content

feat: Add event.type property to Events and Discover #13100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2019
Merged

feat: Add event.type property to Events and Discover #13100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d186d1a
feat: Add type to events/issue search and Discover
lynnagara May 7, 2019
d8a13e9
type -> event.type. Also adds to Events table
lynnagara May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/api/serializers/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ def serialize(self, obj, attrs, user):

return {
'id': six.text_type(obj.id),
'event.type': six.text_type(obj.type),
'groupID': six.text_type(obj.group_id),
'eventID': six.text_type(obj.event_id),
'projectID': six.text_type(obj.project_id),
Expand Down
1 change: 1 addition & 0 deletions src/sentry/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ class SnubaEvent(EventCommon):

# A list of all useful columns we can get from snuba.
selected_columns = minimal_columns + [
'type',
'culprit',
'location',
'message',
Expand Down
1 change: 1 addition & 0 deletions src/sentry/static/sentry/app/actionCreators/tags.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import AlertActions from 'app/actions/alertActions';
const MAX_TAGS = 500;

const BUILTIN_TAGS = [
'event.type',
'platform',
'message',
'title',
Expand Down
1 change: 1 addition & 0 deletions src/sentry/static/sentry/app/views/organizationDiscover/data.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const HIDDEN_TAGS = ['sentry:user', 'sentry:release'];

export const COLUMNS = [
{name: 'id', type: TYPES.STRING},
{name: 'event.type', type: TYPES.STRING},
{name: 'issue.id', type: TYPES.NUMBER},
{name: 'project.id', type: TYPES.STRING},
{name: 'project.name', type: TYPES.STRING},
Expand Down
7 changes: 5 additions & 2 deletions src/sentry/static/sentry/app/views/organizationEvents/eventsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ class EventsTableBody extends React.PureComponent {
</EventTitle>
</TableData>

<TableData>{event['event.type']}</TableData>

<TableData>
{hasSentry10 ? (
idBadge
Expand Down Expand Up @@ -140,6 +142,7 @@ class EventsTable extends React.Component {
<PanelHeader>
<TableLayout>
<div>{t('Event')}</div>
<div>{t('Event Type')}</div>
<div>{t('Project')}</div>
<div>{t('User')}</div>
<div>{t('Time')}</div>
Expand All @@ -148,7 +151,7 @@ class EventsTable extends React.Component {
{loading && <LoadingIndicator />}
{!loading && !hasEvents && (
<EmptyStateWarning>
<p>No events</p>
<p>{t('No events')}</p>
</EmptyStateWarning>
)}
{hasEvents && (
Expand Down Expand Up @@ -177,7 +180,7 @@ const StyledPanelBody = styled(PanelBody)`

const TableLayout = styled('div')`
display: grid;
grid-template-columns: 0.8fr 0.15fr 0.25fr 200px;
grid-template-columns: 0.8fr 0.15fr 0.15fr 0.25fr 200px;
grid-column-gap: ${space(1.5)};
width: 100%;
`;
Expand Down