feat(search-issues): Add message column to search issues #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration search_issues : 0009_add_message
Local op: ALTER TABLE search_issues_local_v2 ADD COLUMN IF NOT EXISTS message String AFTER replay_id;
Distributed op: ALTER TABLE search_issues_dist_v2 ADD COLUMN IF NOT EXISTS message String AFTER replay_id;
-- end forward migration search_issues : 0009_add_message
-- backward migration search_issues : 0009_add_message
Distributed op: ALTER TABLE search_issues_dist_v2 DROP COLUMN IF EXISTS message;
Local op: ALTER TABLE search_issues_local_v2 DROP COLUMN IF EXISTS message;
-- end backward migration search_issues : 0009_add_message |
barkbarkimashark
suggested changes
Jun 20, 2023
There was a problem hiding this comment.
Ahh, damn I missed this column ..
The code looks ok, but I think we'll need to split this PR up into two following steps:
- PR1: Add the migration and include it in
group_loader.py - Merge PR1 and have someone from the SNS team manually run the migration against prod.
- PR2: Start extracting the field in
search_issues_processor, and exposing the field in the storage and entity. - Merge PR2 and deploy snuba.
|
For completeness, you probably also wanna add a processor and api test: snuba/tests/test_search_issues_api.py Line 264 in 173925b |
wedamija
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 20, 2023
…nce titles works as expected This validates that searching for an issue platform issue via text in the title works as expected. Relies on #51325 and getsentry/snuba#4385 Related to #50345
…d it initially.. Related to getsentry/sentry#50345
wedamija
force-pushed
the
danf/search-issues-message
branch
from
e251234 to
f11cd2d
Compare
Tbh I think I missed it in the initial design. Thanks for the feedback, splitting this up now |
wedamija
added a commit
that referenced
this pull request
Jun 21, 2023
This allows the message column on search issues to be queried, and stops using `issue_title`. We won't merge this until we've dual written data for a week or two. Relies on #4385, #4387 Related to getsentry/sentry#50345
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4385 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 802 803 +1
Lines 39375 39388 +13
Branches 245 245
=======================================
+ Hits 35573 35585 +12
- Misses 3770 3771 +1
Partials 32 32
☔ View full report in Codecov by Sentry. |
wedamija
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 21, 2023
…nce titles works as expected This validates that searching for an issue platform issue via text in the title works as expected. Relies on #51325 and getsentry/snuba#4385 Related to #50345
barkbarkimashark
approved these changes
Jun 21, 2023
dbanda
approved these changes
Jun 21, 2023
wedamija
added a commit
that referenced
this pull request
Jun 22, 2023
This allows the message column on search issues to be queried, and stops using `issue_title`. We won't merge this until we've dual written data for a week or two. Relies on #4385, #4387 Related to getsentry/sentry#50345
wedamija
added a commit
that referenced
this pull request
Feb 23, 2024
This allows the message column on search issues to be queried, and stops using `issue_title`. We won't merge this until we've dual written data for a week or two. Relies on #4385, #4387 Related to getsentry/sentry#50345
wedamija
added a commit
that referenced
this pull request
Feb 26, 2024
) This allows the message column on search issues to be queried, and stops using `issue_title`. We won't merge this until we've dual written data for a week or two. Relies on #4385, #4387 Related to getsentry/sentry#50345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
messagecolumn to search issues, since we missed including it a column initially.Related to getsentry/sentry#50345