-
-
Notifications
You must be signed in to change notification settings - Fork 62
feat(search-issues): Make message
column available for querying
#4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83d43dc
to
17770e2
Compare
8c59674
to
51698b5
Compare
We started dual writing today, can merge in a couple weeks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4391 +/- ##
=======================================
Coverage 89.93% 89.93%
=======================================
Files 897 897
Lines 43538 43552 +14
Branches 288 288
=======================================
+ Hits 39155 39168 +13
- Misses 4341 4342 +1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
I think it's possible to add a query processor that falls back to the other column. So you can switch over immediately and keep queries simpler. |
Oh like a coalesce or something along those lines? |
yeah, something like that. Pretty sure you can use the ColumnToFunction mapper to map the |
That isn't currently supported in the YAML right now, so you'd need to write a custom query processor and add it to the config that way. If that's something you want to do we can help with that. As long as it gets removed when the cutover is complete. |
This allows the message column on search issues to be queried, and stops using `issue_title`. We won't merge this until we've dual written data for a week or two. Relies on #4385, #4387 Related to getsentry/sentry#50345
51698b5
to
58791f3
Compare
we noticed prod CI start failing here: https://github.com/getsentry/sentry/actions/runs/8058942260/job/22012542947?pr=65859 we xfailed the test in order to unblock master. #65858 it was determined that this test failure was due to an update made to snuba: getsentry/snuba#4391 where we changed how the message parameter mapped to a clickhouse search column. We change the operator to contains instead of equals, as now the "message" column is filled with additional things. the test should work correctly now. We should do a post-mortem as to why the snuba CI did not catch this test failure. For posterity, developers looking to replicate issues in CI should make sure their local snuba image is up to date with what's in prod (sentry devservices down snuba && sentry devservices up snuba)
This allows the message column on search issues to be queried, and stops using
issue_title
. We won't merge this until we've dual written data for a week or two.Relies on #4385, #4387 Related to getsentry/sentry#50345