Verify memoized files can be reloaded before using them #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
added a commit
that referenced
this pull request
Jul 18, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Jul 18, 2015
As per #246 (comment) replace the commit message by: git-svn: do not reuse caches memoized for a different architecture Reusing cached data speeds up git-svn by quite a fair bit. However, if the YAML module is unavailable, the caches are written to disk in an architecture-dependent manner. That leads to problems when upgrading, say, from 32-bit to 64-bit Git for Windows. Let's just try to read those caches back if we detect the absence of the YAML module and the presence of the file, and delete the file if it could not be read back correctly. Note that the only way to catch the error when the memoized cache could not be read back is to put the call inside an `eval { ... }` block because it would die otherwise; the `eval` block should also return `1` in case of success explicitly since the function reading back the cached data does not return an appropriate value to test for success. This fixes #233. [jes: fixed the commit message, made the sign-off explicit] Signed-off-by: Gavin Lambert <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
|
I took care of it myself: 2893a19 |
dscho
added a commit
that referenced
this pull request
Jul 18, 2015
Verify memoized files can be reloaded before using them
|
Excellent, thank you. |
dscho
added a commit
that referenced
this pull request
Jul 30, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Aug 31, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Sep 10, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Sep 18, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Sep 29, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 5, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 19, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Nov 9, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Dec 11, 2015
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Jan 5, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Jan 28, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Feb 6, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Feb 23, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Mar 15, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Mar 18, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Mar 29, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Apr 4, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Apr 30, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
May 20, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Jun 7, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Jun 9, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Sep 24, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Sep 26, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 3, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 4, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 5, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 5, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 7, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 7, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 9, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 12, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 12, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 13, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 13, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 13, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 15, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 18, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 18, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 18, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Oct 20, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 26, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 27, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 27, 2016
Verify memoized files can be reloaded before using them
dscho
added a commit
that referenced
this pull request
Oct 29, 2016
Verify memoized files can be reloaded before using them
dscho
pushed a commit
that referenced
this pull request
Nov 9, 2016
Verify memoized files can be reloaded before using them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233.