Skip to content

Conversation

@alshopov
Copy link

@alshopov alshopov commented Mar 1, 2025

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

For a single-commit pull request, please leave the pull request description
empty
: your commit message itself should describe your changes.

Please read the "guidelines for contributing" linked above!

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

Errors and warnings found by git-po-helper in workflow #888:

------------------------------------------------------------------------------
INFO [po/bg.po@d695c25]	5832 translated messages. 
------------------------------------------------------------------------------
ERROR [po/bg.po@d695c25]	Found file-location comments in po file. By submitting a location-less 
ERROR [po/bg.po@d695c25]	"po/XX.po" file, the size of the Git repository can be greatly reduced. 
ERROR [po/bg.po@d695c25]	See the discussion below: 
ERROR [po/bg.po@d695c25]                           
ERROR [po/bg.po@d695c25]	    https://lore.kernel.org/git/[email protected]/ 
ERROR [po/bg.po@d695c25]                           
ERROR [po/bg.po@d695c25]	As how to commit a location-less "po/XX.po" file, See: 
ERROR [po/bg.po@d695c25]                           
ERROR [po/bg.po@d695c25]	    the [Updating a "XX.po" file] section in "po/README.md" 
INFO checking commits: 0 passed, 1 failed.        
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@alshopov alshopov force-pushed the master branch 3 times, most recently from d695c25 to 5c94c1a Compare March 2, 2025 12:01
@jiangxin
Copy link
Member

jiangxin commented Mar 5, 2025

Hi,

The 2.49.0 rc1 release introduced a new translatable message. Please rebase your branch and update your commit accordingly.

Thank you!

@alshopov
Copy link
Author

alshopov commented Mar 5, 2025

@jiangxin
I think I already updated the translation.

$ wget https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot

$ msgfmt -v git.pot
0 translated messages, 5832 untranslated messages.

$ msgfmt -v bg.po
5832 translated messages.

Am I missing something?

I think I saw on the build process that there is a check about this - whether any translation was missed. As all checks on the Bulgarian translation are green I believe this is done.

@jiangxin
Copy link
Member

jiangxin commented Mar 5, 2025

Yes, my mistake. I pasted the same message to all open pull requests, but I found the CI for you PR passed. Thank you.

@jiangxin jiangxin mentioned this pull request Mar 6, 2025
@jiangxin
Copy link
Member

jiangxin commented Mar 6, 2025

Yes, my mistake. I pasted the same message to all open pull requests, but I found the CI for you PR passed. Thank you.

There are new changes in Git upstream, see:

https://github.com/git-l10n/pot-changes/blob/pot/master/2025-03-05.diff

@alshopov
Copy link
Author

alshopov commented Mar 6, 2025

There are new changes in Git upstream, see:

Translation updated

@jiangxin jiangxin merged commit b50b68d into git-l10n:master Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants