-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Need to synchronize book images with progit2 repo #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm, we already did this about 6 months ago in 6acf2e4. But then @jnavila pulled images in more recently via 4d71b81, and they seem to be in a different directory. So there are two confusions:
|
|
I did pull them over in #775, and you can see in that diff that the image pulled in there fixed this particular issue. I'm not sure why we're not serving them, though. |
When rewriting the publish system, I had to copy all the files in a flat directory. Hopefully, there is no name collision. Maybe you could rerun your import script (what was the optimization btw?) just to make sure we have the latest version from the book. |
I don't think I actually had an import script. I just did some shell hackery to grab all the images. I'll see if I can do that again, into your flat hierarchy. |
Fixed by #952. |
Just one example: the second figure in Chapter 3's "Basic Merging" section looks like this (linked straight from that site):
…and should look like this (also linked from source):
Note the redundant
C5
in the git-scm.com figure. There have been a number of fixes to the figures since these images were first generated, we should probably re-do whatever it is was done to bring them over in the first place. @schacon, do you still have the script you used for this?The text was updated successfully, but these errors were encountered: