re-import book images from progit2 repo #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did this originally in #775, but the book hierarchy changed to a flat one since then. The new images are missing some updates and fixes.
|
Oh, and I added a short shell script to do the import. It depends on having a progit2 checkout nearby, but I think it's OK for it to be picky. This should only need to be run very occasionally. |
pedrorijo91
approved these changes
Feb 10, 2017
|
I deployed this to the site and confirmed that #515 is now fixed. This should refix the other image problems, too. |
This was referenced Feb 10, 2017
Closed
This was referenced Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did this originally in #775, but the book hierarchy changed to a flat one since then. The new images are missing some updates and fixes.
I've confirmed from the diff that this fixes some issues (e.g., check out
advance-master.pngwhich fixes the flipped commit sha1s).The new images have lower resolution, but I think that's fine. That comes from progit/progit2@3de8ef2, and that's what's been going into the book builds for a long time.
/cc @jnavila @pedrorijo91