Go: extract explicit alias types #18283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
owen-mc
force-pushed
the
go/extract-alias-types
branch
from
1267d6a to
187b5ee
Compare
This makes it clearer when changes in test results are due to changes in the standard library.
Read through as many aliases as possible before getting the underlying type.
Use object like we do for named types.
…on extracting an alias
This means that there is a target for defs and refs to refer to after the original fields go away because their corresponding structs have also gone away on a database downgrade.
…exported methods defined in different packages
They are only used by private predicates. They can be made public in future if needed.
owen-mc
force-pushed
the
go/extract-alias-types
branch
2 times, most recently
from
a68e370 to
fa04ece
Compare
We now see S1 and S2 as two different types, and when you deep-unalias S2 you get S1.
owen-mc
force-pushed
the
go/extract-alias-types
branch
from
fa04ece to
2330145
Compare
Closed
|
We decided not to take this route, as it complicates checking for type equality in QL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #17341. Some tests are giving unexpected results, so there may still be some bugs that I've introduced in rebasing.