Code

Go: extract explicit alias types#18283

Code

Closed

owen-mc wants to merge 43 commits intogithub:maingithub/codeql:mainfrom

owen-mc:go/extract-alias-typesowen-mc/codeql:go/extract-alias-typesCopy head branch name to clipboard

Commits

Commits on Jan 21, 2025

• Go: Update dbscheme for aliases

  

  mbg

  authored and

  owen-mc

  committed
  a8c1b79

  Copy full SHA for a8c1b79

• Go: Extract type aliases

  

  mbg

  authored and

  owen-mc

  committed
  00a5cec

  Copy full SHA for 00a5cec

• Go: Extract alias names

  

  mbg

  authored and

  owen-mc

  committed
  6d61693

  Copy full SHA for 6d61693

• Go: Fix formatting and documentation of `AliasType`

  

  mbg

  authored and

  owen-mc

  committed
  cede0e2

  Copy full SHA for cede0e2

• Go: Update `AliasType` to implement `getUnderlyingType`

  

  mbg

  authored and

  owen-mc

  committed
  5d86410

  Copy full SHA for 5d86410

• Go: Extract objects for aliases

  

  mbg

  authored and

  owen-mc

  committed
  3e061e4

  Copy full SHA for 3e061e4

• Factor out `extractTypeObject`

  owen-mc

  committed
  4141b17

  Copy full SHA for 4141b17

• Fix alias use in HTML template escaping passthrough

  owen-mc

  committed
  5086ee3

  Copy full SHA for 5086ee3

• Use unique type param names in test

  Show description for 6356e55
  owen-mc

  committed
  6356e55

  Copy full SHA for 6356e55

• Fix syntax error in test

  owen-mc

  committed
  0202ddf

  Copy full SHA for 0202ddf

• Improve `AliasType.getUnderlyingType`

  Show description for 8c88bc3
  owen-mc

  committed
  8c88bc3

  Copy full SHA for 8c88bc3

• Update labels for alias types

  Show description for 433e11d
  owen-mc

  committed
  433e11d

  Copy full SHA for 433e11d

• Add change note

  owen-mc

  committed
  68ad213

  Copy full SHA for 68ad213

• Look through aliases in hasOwnField

  

  smowton

  authored and

  owen-mc

  committed
  84686eb

  Copy full SHA for 84686eb

• Implement deep unaliasing, and use it in interface dispatch resolution

  

  smowton

  authored and

  owen-mc

  committed
  8a85026

  Copy full SHA for 8a85026

• Transparent aliases: don't look through named types

  

  smowton

  authored and

  owen-mc

  committed
  5e9bd1a

  Copy full SHA for 5e9bd1a

• Transparent aliases: don't write an invalid type to the @types table on extracting an alias

  

  smowton

  authored and

  owen-mc

  committed
  75afc1b

  Copy full SHA for 75afc1b

• Distinguish types with and without explicit aliases in the type-label cache

  

  smowton

  authored and

  owen-mc

  committed
  62ab941

  Copy full SHA for 62ab941

• Fix Mongodb additional taint step

  

  smowton

  authored and

  owen-mc

  committed
  4411ba9

  Copy full SHA for 4411ba9

• Don't repeat parts of extractType that populate tracking tables

  

  smowton

  authored and

  owen-mc

  committed
  713c9c9

  Copy full SHA for 713c9c9

• Fix flow through pointer types related by aliasing

  

  smowton

  authored and

  owen-mc

  committed
  f0bcd59

  Copy full SHA for f0bcd59

• Fix missed case

  

  smowton

  authored and

  owen-mc

  committed
  00d738d

  Copy full SHA for 00d738d

• Improve efficiency of composite-type deep-unalias computation

  

  smowton

  authored and

  owen-mc

  committed
  acefdbd

  Copy full SHA for acefdbd

• Make deep-unalias computation even more efficient using unpack routines

  

  smowton

  authored and

  owen-mc

  committed
  f71b9e8

  Copy full SHA for f71b9e8

• Only extract transparent-alias versions of types when necessary

  

  smowton

  authored and

  owen-mc

  committed
  ef3515c

  Copy full SHA for ef3515c

• Fix struct deepUnaliasedType predicate

  

  smowton

  authored and

  owen-mc

  committed
  df77477

  Copy full SHA for df77477

• Implement deep-unalias for interface types

  

  smowton

  authored and

  owen-mc

  committed
  707f10d

  Copy full SHA for 707f10d

• Fix TupleType's getDeepUnaliasedType, and make it efficient

  

  smowton

  authored and

  owen-mc

  committed
  3c5e7ab

  Copy full SHA for 3c5e7ab

• autoformat and tidy an unnecessary direct db relation use

  

  smowton

  authored and

  owen-mc

  committed
  94a6373

  Copy full SHA for 94a6373

• Interface unaliasing: don't confuse the empty interface with the type 'comparable'

  

  smowton

  authored and

  owen-mc

  committed
  f837504

  Copy full SHA for f837504

• Ensure fields are created for de-aliased struct types

  Show description for 14ef824
  

  smowton

  authored and

  owen-mc

  committed
  14ef824

  Copy full SHA for 14ef824

• Interface types: distinguish otherwise-identical interfaces with non-exported methods defined in different packages

  owen-mc

  committed
  84d7828

  Copy full SHA for 84d7828

• Upgrade/downgrade scripts

  owen-mc

  committed
  ad227e3

  Copy full SHA for ad227e3

• Accept test changes

  owen-mc

  committed
  a602fec

  Copy full SHA for a602fec

• Make four predicates private

  Show description for 48d53f4
  owen-mc

  committed
  48d53f4

  Copy full SHA for 48d53f4

Commits on Jan 22, 2025

• Fix bug with empty struct tags

  owen-mc

  committed
  727c19c

  Copy full SHA for 727c19c

• Be more careful about type equivalence up to aliasing in read steps

  owen-mc

  committed
  df7a54b

  Copy full SHA for df7a54b

Commits on Jan 24, 2025

• Fix test to gave almost the same results

  owen-mc

  committed
  0a91a9d

  Copy full SHA for 0a91a9d

• Make comment clearer

  owen-mc

  committed
  f4dce0d

  Copy full SHA for f4dce0d

• Accept expected test result

  Show description for b8724f7
  owen-mc

  committed
  b8724f7

  Copy full SHA for b8724f7

• Fix bug re: methods defined via aliases

  owen-mc

  committed
  38831f2

  Copy full SHA for 38831f2

• Update test to avoid duplicates

  owen-mc

  committed
  d53d024

  Copy full SHA for d53d024

Commits on Jan 27, 2025

• Changed test expectations to investigate

  owen-mc

  committed
  2330145

  Copy full SHA for 2330145