CPP: Fix type confusion in IncorrectPointerscaling.ql #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
approved these changes
Dec 10, 2018
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Post-release preparation for codeql-cli-2.7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix false positives in IncorrectPointerscaling.ql caused by type confusion in pointer parameters, such as this case:
https://lgtm.com/projects/g/NVIDIAGameWorks/PhysX-3.4/snapshot/7824041cdbe617fcb8d905c36bdb0db06c77a75c/files/PhysX_3.4/Source/SceneQuery/src/SqBucketPruner.cpp?sort=name&dir=ASC&mode=heatmap#L343
After this is merged I plan to create an
IncorrectPointerScaling.qlllibrary to remove some of the code duplication you can see in the three similar queries.