Skip to content

C#: Remove cs/non-short-circuit query #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

C#: Remove cs/non-short-circuit query #651

wants to merge 1 commit into from

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 10, 2018

No description provided.

@hvitved hvitved added the C# label Dec 10, 2018
@hvitved hvitved requested a review from calumgrant December 10, 2018 10:48
@hvitved hvitved requested a review from a team as a code owner December 10, 2018 10:48
@calumgrant
Copy link
Contributor

This query could guard other things besides null checks. Therefore, I don't think this query is truly superseded by the nullness queries. It's also quite useful to be told why a nullness query has been triggered, which could be due to a &/&& typo, but it may not be immediately obvious.

@hvitved
Copy link
Contributor Author

hvitved commented Dec 14, 2018

This query could guard other things besides null checks.

In my experience, this query only produces poor results, except for results of the form x != null & x.Foo() and x == null | x.Foo(). Can you think of other good results?

@hvitved hvitved closed this Jun 28, 2019
cklin pushed a commit that referenced this pull request May 23, 2022
@owen-mc
Merge pull request #651 from erik-krogh/patches
daa55ea 
various automatic patches applied to codeql-go
@aliscco aliscco mentioned this pull request Feb 23, 2024
Open
@verdinjoshua1982 verdinjoshua1982 mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calumgrant calumgrant Awaiting requested review from calumgrant

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @calumgrant