Skip to content

C#: Remove cs/non-short-circuit query #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion change-notes/1.20/analysis-csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@

| *@name of query (Query ID)* | *Impact on results* | *How/why the query has changed* |
|------------------------------|------------------------|-----------------------------------|
| Off-by-one comparison against container length (cs/index-out-of-bounds) | Fewer false positives | Results have been removed when there are additional guards on the index. |
| Dereferenced variable is always null (cs/dereferenced-value-is-always-null) | Improved results | The query has been rewritten from scratch, and the analysis is now based on static single assignment (SSA) forms. The query is now enabled by default in LGTM. |
| Dereferenced variable may be null (cs/dereferenced-value-may-be-null) | Improved results | The query has been rewritten from scratch, and the analysis is now based on static single assignment (SSA) forms. The query is now enabled by default in LGTM. |
| Off-by-one comparison against container length (cs/index-out-of-bounds) | Fewer false positives | Results have been removed when there are additional guards on the index. |
| Potentially dangerous use of non-short-circuit logic (cs/non-short-circuit) | No results | The query has been removed as it has been superseded by the queries Dereferenced variable is always null (cs/dereferenced-value-is-always-null) and Dereferenced variable may be null (cs/dereferenced-value-may-be-null). |

## Changes to code extraction

Expand Down
11 changes: 0 additions & 11 deletions csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.cs

This file was deleted.

35 changes: 0 additions & 35 deletions csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.qhelp

This file was deleted.

57 changes: 0 additions & 57 deletions csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.ql

This file was deleted.

11 changes: 0 additions & 11 deletions csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogicFix.cs

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.