-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JavaScript: Remove deprecated APIs. #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is it worth adding a change note for this for people who only upgrade occasionally? We added a brief note for #733 which also removed a deprecated data flow library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo documentation.
685cf05
to
8944784
Compare
I've added a change note for the two libraries that have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The old data flow library was deprecated in 1.17, as was the backward-compatibility layer in the security queries. The old call graph library has been deprecated since 1.18. Some of the minor stuff was, I think, only deprecated in 1.19, but I think one release cycle is enough since equivalent API is available.