Skip to content

JavaScript: Remove deprecated APIs. #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2019

Conversation

xiemaisi
Copy link

@xiemaisi xiemaisi commented Jan 9, 2019

The old data flow library was deprecated in 1.17, as was the backward-compatibility layer in the security queries. The old call graph library has been deprecated since 1.18. Some of the minor stuff was, I think, only deprecated in 1.19, but I think one release cycle is enough since equivalent API is available.

@xiemaisi xiemaisi added the JS label Jan 9, 2019
@xiemaisi xiemaisi requested a review from a team as a code owner January 9, 2019 08:53
@felicitymay
Copy link
Contributor

Is it worth adding a change note for this for people who only upgrade occasionally? We added a brief note for #733 which also removed a deprecated data flow library.

ghost
ghost previously approved these changes Jan 9, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo documentation.

@xiemaisi xiemaisi force-pushed the js/remove-deprecated branch from 685cf05 to 8944784 Compare January 9, 2019 09:24
@xiemaisi
Copy link
Author

xiemaisi commented Jan 9, 2019

I've added a change note for the two libraries that have been removed.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 7973460 into github:master Jan 9, 2019
@xiemaisi xiemaisi deleted the js/remove-deprecated branch January 10, 2019 16:25
cklin pushed a commit that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants