Skip to content

JavaScript: Remove deprecated APIs. #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2019
Merged

JavaScript: Remove deprecated APIs. #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
feb9693
JavaScript: Remove old data flow library.
Jan 8, 2019
db713fb
JavaScript: Remove deprecated backward-compatibility layer in securit…
Jan 8, 2019
5d1d94e
JavaScript: Remove deprecated old call graph library.
Jan 8, 2019
8a93c6a
JavaScript: Remove a few deprecated classes.
Jan 8, 2019
db8e436
JavaScript: Remove deprecated flow tracking predicates.
Jan 8, 2019
97e6c75
JavaScript: Remove a few other deprecated predicates and classes.
Jan 8, 2019
8944784
JavaScript: Add change note.
Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions change-notes/1.20/analysis-javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@

* `DataFlow::SourceNode` is no longer an abstract class; to add new source nodes, extend `DataFlow::SourceNode::Range` instead.
* Subclasses of `DataFlow::PropRead` are no longer automatically made source nodes; you now need to additionally define a corresponding subclass of `DataFlow::SourceNode::Range` to achieve this.
* The deprecated libraries `semmle.javascript.DataFlow` and `semmle.javascript.dataflow.CallGraph` have been removed; they are both superseded by `semmle.javascript.dataflow.DataFlow`.
2 changes: 0 additions & 2 deletions javascript/ql/src/javascript.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import semmle.javascript.Classes
import semmle.javascript.Comments
import semmle.javascript.Concepts
import semmle.javascript.Constants
import semmle.javascript.DataFlow
import semmle.javascript.DefUse
import semmle.javascript.DOM
import semmle.javascript.EmailClients
Expand Down Expand Up @@ -49,7 +48,6 @@ import semmle.javascript.Util
import semmle.javascript.Variables
import semmle.javascript.XML
import semmle.javascript.YAML
import semmle.javascript.dataflow.CallGraph
import semmle.javascript.dataflow.DataFlow
import semmle.javascript.dataflow.TaintTracking
import semmle.javascript.dataflow.TypeInference
Expand Down
8 changes: 0 additions & 8 deletions javascript/ql/src/semmle/javascript/AMD.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@ class AMDModuleDefinition extends CallExpr {
result = getARequireCall().getAnArgument()
}

/**
* DEPRECATED: Use `getFactoryNode` instead.
*
* Gets the factory expression of this module definition,
* which may be a function or a literal.
*/
deprecated Expr getFactoryExpr() { result = getFactoryNode().asExpr() }

/**
* Gets a data flow node containing the factory value of this module definition.
*/
Expand Down
14 changes: 0 additions & 14 deletions javascript/ql/src/semmle/javascript/CanonicalNames.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,6 @@ class TypeName extends CanonicalName {
*/
TypeReference getATypeReference() { result.getTypeName() = this }

/**
* DEPRECATED. Use `getRelativeName()` or `hasQualifiedName()` instead.
*
* Gets the qualified name without the root.
*/
deprecated string getQualifiedName() { result = getRelativeName() }

/**
* Gets a type named in the `extends` or `implements` clause of this type.
*/
Expand Down Expand Up @@ -265,13 +258,6 @@ class Namespace extends CanonicalName {
*/
NamespaceAccess getAnAccess() { result.getNamespace() = this }

/**
* DEPRECATED. Use `getRelativeName()` or `hasQualifiedName()` instead.
*
* Gets the qualified name without the root.
*/
deprecated string getQualifiedName() { result = getRelativeName() }

/** Gets a namespace nested in this one. */
Namespace getNamespaceMember(string name) {
result.getParent() = this and
Expand Down
9 changes: 0 additions & 9 deletions javascript/ql/src/semmle/javascript/Comments.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,6 @@ class HtmlCommentStart extends @htmlcommentstart, HtmlLineComment { }
/** An HTML comment end token interpreted as a line comment. */
class HtmlCommentEnd extends @htmlcommentend, HtmlLineComment { }

/** DERECATED: Use `HtmlLineComment` instead. */
deprecated class HTMLComment = HtmlLineComment;

/** DERECATED: Use `HtmlCommentStart` instead. */
deprecated class HTMLCommentStart = HtmlCommentStart;

/** DERECATED: Use `HtmlCommentEnd` instead. */
deprecated class HTMLCommentEnd = HtmlCommentEnd;

/** A `//` comment. */
class SlashSlashComment extends @slashslashcomment, LineComment { }

Expand Down
Loading