Change coordinates column in checkpoint table to TEXT
#1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyedison
approved these changes
Dec 3, 2025
Copilot finished reviewing on behalf of
meiji163
December 3, 2025 01:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the gh_ost_chk_coords column in the checkpoint table from VARCHAR(4096) to TEXT with ASCII charset to support storing larger GTID sets (up to 65,535 characters).
Key changes:
- Column type changed from
VARCHAR(4096)toTEXT charset asciito accommodate GTID sets that can exceed the previous 4,096 character limit
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "`gh_ost_chk_id` bigint auto_increment primary key", | ||
| "`gh_ost_chk_timestamp` bigint", | ||
| "`gh_ost_chk_coords` varchar(4096)", | ||
| "`gh_ost_chk_coords` text charset ascii", |
There was a problem hiding this comment.
The column definition should include an explicit NULL constraint specification. While TEXT columns are nullable by default, it's best practice to be explicit about nullability for clarity and consistency. Consider whether this column should be NOT NULL (like the similar value column in the changelog table at line 407) or explicitly allow NULL.
Suggested change
| "`gh_ost_chk_coords` text charset ascii", | |
| "`gh_ost_chk_coords` text charset ascii NOT NULL", |
|
Yes
في الأربعاء، 3 ديسمبر 2025، 4:54 ص Andy Edison ***@***.***>
كتب:
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1611 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWKM54FSB7QWTR3VQAZCNW337Y7FZAVCNFSM6AAAAACN3SDEK2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMZSHAZTSOBZGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
gh_ost_chk_coordscolumn in the checkpoint table fromVARCHAR(4096)to asciiTEXTcolumn, so it can store GTID sets up to 65,535 characters long.script/cibuildreturns with no formatting errors, build errors or unit test errors.