Skip to content

Change coordinates column in checkpoint table to TEXT #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiji163 merged 1 commit into from
Dec 5, 2025
Merged

Change coordinates column in checkpoint table to TEXT #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/logic/applier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ func (this *Applier) CreateCheckpointTable() error {
colDefs := []string{
"`gh_ost_chk_id` bigint auto_increment primary key",
"`gh_ost_chk_timestamp` bigint",
"`gh_ost_chk_coords` varchar(4096)",
"`gh_ost_chk_coords` text charset ascii",
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column definition should include an explicit NULL constraint specification. While TEXT columns are nullable by default, it's best practice to be explicit about nullability for clarity and consistency. Consider whether this column should be NOT NULL (like the similar value column in the changelog table at line 407) or explicitly allow NULL.

Suggested change
"`gh_ost_chk_coords` text charset ascii",
"`gh_ost_chk_coords` text charset ascii NOT NULL",

Copilot uses AI. Check for mistakes.
"`gh_ost_chk_iteration` bigint",
"`gh_ost_rows_copied` bigint",
"`gh_ost_dml_applied` bigint",
Expand Down
Loading