Skip to content

Fix issue with alternate fields not being mapped. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue with alternate fields not being mapped. #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2013

Net::LDAP::Entry returns an empty array if the key does not exist, so
this checks for the key.

This replaces PR #6 by using the code from omniauth@b524feb rather than flattening. The end result is the same.

Net::LDAP::Entry returns an empty array if the key does not exist, so
this checks for the key.
@ghost
Copy link
Author

ghost commented Dec 23, 2013

@randx Any chance this can get merged and new a gem released? This is really needed in order for alternates to work as Net::LDAP::Entry always returns an array, which causes nil to be set rather than the alternate field values.

@ghost ghost mentioned this pull request Jan 31, 2014
@ghost
Copy link
Author

ghost commented Jan 31, 2014

Replaced with PR #10.

@ghost ghost closed this Jan 31, 2014
@ghost ghost deleted the fix/alternate-fields branch February 4, 2014 01:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

0 participants