Fix issue with alternate fields not being mapped. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Net::LDAP::Entry returns an empty array if the key does not exist, so this checks for the key.
|
@randx Any chance this can get merged and new a gem released? This is really needed in order for alternates to work as Net::LDAP::Entry always returns an array, which causes nil to be set rather than the alternate field values. |
ghost
mentioned this pull request
|
Replaced with PR #10. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::LDAP::Entry returns an empty array if the key does not exist, so
this checks for the key.
This replaces PR #6 by using the code from omniauth@b524feb rather than flattening. The end result is the same.