Sync with intridea/omniauth-ldap #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net::LDAP::Entry returns empty array if key not exists, so we should check for key with respond_to?
When exception is raised from middleware host application can not handle it. This is why OmniAuth uses #failure! which sends message to application so it can do something about it
AD allows bind with with correct username and empty password so application will think user successfully authenticated which is a serious mistake
Reformatted specs and reworked way to propagate InvalidCredentials error to application
This way it can be used with rubygems.org API
The Gemfile.lock shouldn't be included in a gem-based repository because it may artificially lock obsolete gems. An example of this is rb-fsevent which at the version it was locked at is incompatable with OS X 10.8 If something does need the version locked, specify it in the .gemspec or Gemfile itself.
…into syndicut-map-userinfo-fix Conflicts: spec/omniauth/strategies/ldap_spec.rb
add license information to the gemspec
gitignore Gemfile.lock
Update net-ldap gem to avoid errors with some LDAP Servers
Minor documentation fix
…agecorp-master Conflicts: README.md spec/omniauth/strategies/ldap_spec.rb
Update version to match intridea/omniauth-ldap. Add test for alternate fields.
|
@randx Any chance this can get merged? There are a few things broken with the current implementation and this addresses those. I made sure that none of the existing functionality was changed (as can be seen by the tests). |
ghost
mentioned this pull request
|
@jhollingsworth looks good. I will merge it |
dzaporozhets
added a commit
that referenced
this pull request
Feb 1, 2014
Sync with intridea/omniauth-ldap
|
@jhollingsworth I expect you want me to build new gem version? |
|
@randx That would be nice to have with the next GitLab release. I currently have my system all patched up. Thanks for doing this. |
This was referenced Feb 1, 2014
| @@ -3,7 +3,6 @@ | |||
| module OmniAuth | |||
| module Strategies | |||
| class LDAP | |||
| class MissingCredentialsError < StandardError; end | |||
There was a problem hiding this comment.
Never mind, it looked for a minute like we were no longer raising an error for missing credentials. I see it uses the fail! method now.
ghost
deleted the
|
Regarding #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some useful updates in https://github.com/intridea/omniauth-ldap. This merges the current master of https://github.com/intridea/omniauth-ldap into https://github.com/gitlabhq/omniauth-ldap. This merge should handle PR #3, PR #6 and PR #7.
Why this as opposed to PR #9? It appears PR #9 missed some commits from https://github.com/intridea/omniauth-ldap and those meet the needs of PR #3.