Do not close the editor or repository selection menu in the new start with options modal when typing a whitespace character (space)

[gtsiolis]

Bug description

Following up from #15567 (Cc @svenefftinge @easyCZ), searching for editor name with a whitespace character in the name, like "VS Code" or "IntelliJ IDEA", does not work and closes the selection menu without selecting any option.

Steps to reproduce

1. Open the new workspace modal with options.
2. Try typing "VS Code"

☝️ The same issue affects selecting a repository.

Untitled.mov

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

[vedant-jain03]

@gtsiolis I would like to work on this issue!

[svenefftinge]

Tricky. Being able to open and close a dropdown using space is a convenient and common interaction I think. Maybe we can detect somehow that it doesn't do this when the focus is in a textinput?

[vedant-jain03]

Tricky. Being able to open and close a dropdown using space is a convenient and common interaction I think. Maybe we can detect somehow that it doesn't do this when the focus is in a textinput?

Right, can we do something like:

• When the input is empty we can use space to toggle the dropdown.
• When the input is not empty we can use the space for concatenation to the input.

@svenefftinge WDYT?

[svenefftinge]

Yes, that sounds good to me. @gtsiolis wdyt?

[gtsiolis]

@svenefftinge This sounds like a good next iteration.

---

Some more thoughts on the topic. Cc @vedant-jain03

Being able to open and close a dropdown using space is a convenient and common interaction I think.

True but only when the component is behaving like a regular select element with a fixed range of options where a user user can select one or none, but without any search options or additional actions, etc.

☝️ In the case of a regular select, pressing space should 🅰️ select the hovered option and close the dropdown or 🅱️ just close the dropdown without any options to the selected item.

Pressing Space to select/deselect "focused" select options.

In the workspace class selection closing the dropdown would make more sense when pressing space, just like when pressing escape. ✔️

☝️ However, that's only if by default there was a pre-selected option as seen in the closed dropdown. This could probably this change regardless of the interaction. Opened #15912 to keep track of this.

[vedant-jain03]

@svenefftinge This sounds like a good next iteration.

Some more thoughts on the topic. Cc @vedant-jain03

Being able to open and close a dropdown using space is a convenient and common interaction I think.

True but only when the component is behaving like a regular select element with a fixed range of options where a user user can select one or none, but without any search options or additional actions, etc.

point_up In the case of a regular select, pressing space should a select the hovered option and close the dropdown or b just close the dropdown without any options to the selected item.

Pressing Space to select/deselect "focused" select options.

In the workspace class selection closing the dropdown would make more sense when pressing space, just like when pressing escape. heavy_check_mark

point_up However, that's only if by default there was a pre-selected option as seen in the closed dropdown. This could probably this change regardless of the interaction. Opened #15912 to keep track of this.

Agreed with your point @gtsiolis, I have open a PR for this iteration #15889.