-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] support start-with-options URL #15567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-se-show-options.1 because the annotations in the pull request description changed |
c956ec1
to
39c9e63
Compare
39c9e63
to
b2d89e7
Compare
/hold |
Currently, the query params contain two params to indicate which IDE to use. There's Could we merge these into a single param? Could we have When I use the following URL: |
When I specify an editor which is not a valid value, the popup shows nothing for that field. I think there should be an error message to indicate the editor is not available - this could happen when new/old editors are removed and/or the URL params change The same happens when I specify a |
I agree it's an unknown concept. I'm not sure |
My point is that |
@svenefftinge |
It's not easy. What do you think of |
/werft run 👍 started the job as gitpod-build-se-show-options.4 |
Sounds much friendlier than Context URL, and we can still mention the term context URL in the modal description or the dropdown second line. Minor issue here would be that it's conflicting with what we call repository context—maybe something to consider renaming to something like default context?
Yes! Besides the abstraction, the context term can be easily confusing or misunderstood. |
Thanks for pointing to the docs, where we name this "Context URL". I think we should be consistent and have the discussion for a better term separately. |
DEAL 🤝 |
With this you would get the Edit: just realized that in preview envs there is only a latest version for VS Code, so you probably expected this to be an alias for "VS Code Latest". It is meant to be an orthogonal information that can be applied to any of the editors (if a latest version is available) We could merge it e.g. as |
b2d89e7
to
b835912
Compare
/unhold |
/werft run 👍 started the job as gitpod-build-se-show-options.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is now good enough to land. We can tweak it in follow-up PRs.
Description
This change allows for starting new workspaces with an option dialog where users can select the IDE and workspace class.
The URL param is
showOptions=true
as in:https://gitpod.io?showOptions=true#<context-url>
Related Issue(s)
Fixes #15566
How to test
Open this PR using the following link:
It's also possible to preselect certain values:
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh