-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[preview] Apply gitpod/monitoring-satellite resources if there's diff #16517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12bb78c
to
5117ed2
Compare
5117ed2
to
6b5bcd9
Compare
started the job as gitpod-build-aa-deploy.6 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
started the job as gitpod-build-aa-deploy.7 because the annotations in the pull request description changed |
This is a brand new instance, nothing has been rendered, but some of them have produced no diff, which proves that many have been applied multiple times |
Should we revert this PR? this PR block #16523 cc @mads-hartmann because @vulkoingim is OOO |
@iQQBot Let's revert it - if you create a PR I can approve the changes to get it through |
Description
Apply gitpod/monitoring-satellite resources only if there's a diff with the one in the cluster. Fixes some issues where resources exist when applied twice, and also should speed up the process somewhat
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh