Skip to content

[preview] Apply gitpod/monitoring-satellite resources if there's diff #16517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Feb 22, 2023

Description

Apply gitpod/monitoring-satellite resources only if there's a diff with the one in the cluster. Fixes some issues where resources exist when applied twice, and also should speed up the process somewhat

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-deploy.6 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-deploy.7 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit c487681 into main Feb 23, 2023
@roboquat roboquat deleted the aa/deploy branch February 23, 2023 09:08
@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2023

image

I think this PR brings more instability to the preview env, and there may be competition between them

@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2023

This is a brand new instance, nothing has been rendered, but some of them have produced no diff, which proves that many have been applied multiple times

@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2023

image

image

image

if you see github action, there are lots of preview env created that failed because of this.

@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2023

Should we revert this PR? this PR block #16523 cc @mads-hartmann because @vulkoingim is OOO

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Mar 2, 2023

@iQQBot Let's revert it - if you create a PR I can approve the changes to get it through ☺️ Then @vulkoingim can debug further when he gets back ☺️

iQQBot added a commit that referenced this pull request Mar 2, 2023
iQQBot added a commit that referenced this pull request Mar 3, 2023
roboquat pushed a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants