Skip to content

[preview] fix wait, diff-apply, regression-check slack #16842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Mar 14, 2023

Description

Fixes:

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-wait-for-types-not-pods.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-wait-for-types-not-pods.2 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim vulkoingim marked this pull request as ready for review March 14, 2023 13:02
@vulkoingim vulkoingim requested a review from a team March 14, 2023 13:02
@vulkoingim vulkoingim force-pushed the aa/wait-for-types-not-pods branch from 188effa to bfe5b01 Compare March 14, 2023 14:13
@vulkoingim vulkoingim force-pushed the aa/wait-for-types-not-pods branch from bfe5b01 to 2fd169d Compare March 15, 2023 08:09
@roboquat roboquat merged commit 2374815 into main Mar 15, 2023
@roboquat roboquat deleted the aa/wait-for-types-not-pods branch March 15, 2023 08:35
@kylos101
Copy link
Contributor

@vulkoingim @mads-hartmann we are blocked from deploying, the Workspace Integration tests are failing, and we generally require tests to be green before deploying.

  1. When triggered from werft, the preview create cannot find the werft namespace after doing many diffs.
    • I think that is related to this PR.
    • Can you help?
    • Being able to run again in werft until our new Workspace Integration Test GHA is stable would prove helpful for the team.
  2. I tried running the tests manually as a workaround from /test via ./run.sh -s workspace, but, the preview environment appears to be in an odd state, which is resulting in test failures for minio and our content-service.
    • I plan to recreate the preview environment, and try again Friday to debug.
    • The errors for reference indicate a mismatch between the configured minio secret, and what content-service is using:
[test-workspace-parallel] === RUN   TestUploadDownloadBlob/UploadDownloadBlob/it_should_upload_and_download_blob
[test-workspace-parallel]     content-service_test.go:192: rpc error: code = NotFound desc = The Access Key Id you provided does not exist in our records.
[test-workspace-parallel] --- FAIL: TestUploadDownloadBlob (5.07s)
[test-workspace-parallel]     --- FAIL: TestUploadDownloadBlob/UploadDownloadBlob (5.07s)
[test-workspace-parallel]         --- FAIL: TestUploadDownloadBlob/UploadDownloadBlob/it_should_upload_and_download_blob (5.07s)

[test-workspace-parallel]     content_test.go:397: rpc error: code = Unknown desc = The Access Key Id you provided does not exist in our records.
[test-workspace-parallel] --- FAIL: TestMissingBackup (24.81s)
[test-workspace-parallel]     --- FAIL: TestMissingBackup/CreateWorkspace (24.81s)
[test-workspace-parallel]         --- FAIL: TestMissingBackup/CreateWorkspace/it_ensures_workspace_fail_if_they_should_have_a_backup_but_don't_have_one (24.81s)

@corneliusludmann for 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants