Update project cards style and layout #5098
Conversation
There was a problem hiding this comment.
Phew! Replaced some classes to use fixed dimensions. Left some links blank to be replaced with links to actual pages. Feel free to pick this up and add the missing links. Cc @AlexTugarev @jankeromnes 🏀
|
Notes:
|
|
LGTM label has been added. Git tree hash: 3962bdac4c4a782ac2fcf8331b17458cc012b5ef
|
Co-authored-by: Jan Keromnes <[email protected]>
|
New changes are detected. LGTM label has been removed. |
| <img className="h-3 w-3 my-auto" src={getPrebuildStatusIcon(lastPrebuilds.get(p.id)!.status)} /> | ||
| <div className="my-auto font-semibold text-gray-400 truncate w-24" title={lastPrebuilds.get(p.id)!.branch}>{lastPrebuilds.get(p.id)!.branch}</div> | ||
| <span className="mx-1 my-auto text-gray-600">·</span> | ||
| <div className="my-auto text-gray-500 flex-grow hover:text-gray-800 dark:hover:text-gray-300">{moment(lastPrebuilds.get(p.id)!.startedAt, "YYYYMMDD").fromNow()}</div> |
There was a problem hiding this comment.
issue: Just noticed that this always shows 20 hours ago for two random projects while trigger time within the prebuild page is different for both. Expected? 💭
|
Posting some before and after screenshots here:
|
gtsiolis
force-pushed
the
gt/update-project-cards-layout
branch
from
36b0d55 to
25a4880
Compare
|
(Side note: When pushing minor new changes, please feel free to "carry over" the |
|
/lgtm this is very nice! |
|
Documentation or didn't see this! Cc @leodido 🤓 |
|
/lgtm
|
|
@gtsiolis: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, gtsiolis, jankeromnes Associated issue: #4420 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
A minor facelift on the project cards. 🔮
This will fix #4420 (see #4420 (comment)) and #5003.