Skip to content

[projects] Fix rendering of startedAt attribute #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 30, 2021

Description

Fixes rendering rendering of a timestamp

Related Issue(s)

Fixes #5518

How to test

Release Notes

NONE

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Oct 1, 2021

/werft run

👍 started the job as gitpod-build-alex-latest-prebuild-timestamp-5518.1

@AlexTugarev AlexTugarev force-pushed the alex/latest-prebuild-timestamp-5518 branch from 569f329 to fa30af4 Compare October 1, 2021 07:21
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #5961 (fa30af4) into main (ca51c38) will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5961      +/-   ##
==========================================
+ Coverage   36.87%   37.95%   +1.08%     
==========================================
  Files          18       16       -2     
  Lines        4320     4152     -168     
==========================================
- Hits         1593     1576      -17     
+ Misses       2600     2451     -149     
+ Partials      127      125       -2     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 37.95% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/terminal/terminal.go 63.27% <0.00%> (-1.24%) ⬇️
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/ports/ports.go 61.79% <0.00%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca51c38...fa30af4. Read the comment docs.

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good and works for me! (Layout issues for 'small 15" retina screens' aside 😋)

Screenshot 2021-10-01 at 09 30 41

/approve

@roboquat
Copy link
Contributor

roboquat commented Oct 1, 2021

LGTM label has been added.

Git tree hash: 82dc0734429384df02af5ceed3b1fb7863195bc8

@roboquat
Copy link
Contributor

roboquat commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #5518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 89754f7 into main Oct 1, 2021
@roboquat roboquat deleted the alex/latest-prebuild-timestamp-5518 branch October 1, 2021 07:32
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 1, 2021

issue: FYI, Prebuilds in this preview environment fail with the following error but maybe this is expected?

Error: image build did not produce a workspace image

🍊 🍊 🍊 🍊

Opened a follow up issue for #5978.

Cc @jankeromnes @AlexTugarev

@csweichel
Copy link
Contributor

csweichel commented Oct 1, 2021

issue: FYI, Prebuilds in this preview environment fail with the following error but maybe this is expected?

Error: image build did not produce a workspace image

🍊 🍊 🍊 🍊

Opened a follow up issue for #5978.

Cc @jankeromnes @AlexTugarev

No. This is an image-builder-mk3 issue. It turns out that it's really really hard to just copy an image from A to B :/
I've filed an issue: #5981

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 1, 2021

Thanks for coming back to this and linking the new issue, @csweichel! 🏓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest prebuild timestamp is inaccurate on the project card
5 participants