-
Notifications
You must be signed in to change notification settings - Fork 1.3k
WIP: Base server for go #9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Base server for go #9096
Conversation
"net/http" | ||
) | ||
|
||
type config struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should export this so that we can reuse this config in the installer and component config.
We'd want to pull in pprof and prometheus, too.
|
||
var healthyResponse = []byte(`healthy`) | ||
|
||
func ReadyHandler() http.Handler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registry-facade and others use a Kubernetes package for their readiness probes. We should re-use that and promote their use rather than rolling our own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, makes sense. The idea here is that when you get a server, it already comes with sensible defaults. What does are is entirely up to us.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Landed incrementally as part of #9229, closing. |
Description
Introduces a library called
baseserver
. It is a combination of an HTTP and gRPC server designed to make it dead-easy to get sensible defaults and be able to use a server.Using a common base server can give us the following benefits:
To fulfill the role outlined above, the following will be needed as well. These will be added incrementally as we need them.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
/uncc
/hold