Skip to content

enable indexing with GoLand latest in prebuild as well #9246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 12, 2022

Description

This PR:

  • separates system directories for stable and latest versions to allow independent indexing
  • enable GoLand indexing for stable and latest versions in this repo

Related Issue(s)

Related to #6740

How to test

Stable

Latest

Release Notes

NONE

Documentation

@akosyakov akosyakov force-pushed the ak/goland_latest_indexing branch 2 times, most recently from 93fe084 to f0507b4 Compare April 12, 2022 11:50
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@akosyakov akosyakov marked this pull request as ready for review April 13, 2022 08:52
@akosyakov akosyakov requested a review from a team April 13, 2022 08:52
@akosyakov akosyakov requested review from easyCZ and felladrin April 13, 2022 08:53
Comment on lines +7 to +10
PRODUCT_CODE=GO
curl -sSL "https://data.services.jetbrains.com/products?code=$PRODUCT_CODE&fields=distributions%2Clink%2Cname%2Creleases&_=$(date +%s)000" > /tmp/jb_products.xml
JB_BACKEND_DOWNLOAD_URL=$(jq -r '.[0].releases[0].downloads.linux.link' /tmp/jb_products.xml)
echo "$JB_BACKEND_DOWNLOAD_URL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could possibly use https://download.jetbrains.com/product?distribution=linux&code=$PRODUCT_CODE here too. [1]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm not sure. It seems to have another semantic.

Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested! ✅

No more indexing for Go files when opening Gitpod repo on latest version of Goland 🎉

@roboquat roboquat merged commit a4234aa into main Apr 13, 2022
@roboquat roboquat deleted the ak/goland_latest_indexing branch April 13, 2022 09:25
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants